A few mistakes?

[Obsidian]

In the description for the library forum, the link is bad. It's pointed at http://local.phpbbmodders.net/about/lib/ and not http://phpbbmodders.net/about/lib/

Also, for the article regarding debug...I think there is a mistake.

DEBUG will add the page generation time and the number of queries to the footer. It will also allow you to analyse the SQL by adding ?explain=1 to the url bar.

I've never seen the SQL Report link in the debug info when I'm running under debug, only when I'm running under debug extra.

Slacker OUT.

[igorw]

Thanks for the reports, i've fixed that link. For articles you can contact the author or the KB team (also via contact form) directly.

But you are correct. I must have skipped something when writing the article. See, here's the code from the page_footer() function:

Code: Select all

   // Output page creation time
   if (defined('DEBUG'))
   {
      $mtime = explode(' ', microtime());
      $totaltime = $mtime[0] + $mtime[1] - $starttime;

      if (!empty($_REQUEST['explain']) && $auth->acl_get('a_') && defined('DEBUG_EXTRA') && method_exists($db, 'sql_report'))
      {
         $db->sql_report('display');
      }

      $debug_output = sprintf('Time : %.3fs | ' . $db->sql_num_queries() . ' Queries | GZIP : ' . (($config['gzip_compress']) ? 'On' : 'Off') . (($user->load) ? ' | Load : ' . $user->load : ''), $totaltime);

      if ($auth->acl_get('a_') && defined('DEBUG_EXTRA'))
      {
         if (function_exists('memory_get_usage'))
         {
            if ($memory_usage = memory_get_usage())
            {
               global $base_memory_usage;
               $memory_usage -= $base_memory_usage;
               $memory_usage = get_formatted_filesize($memory_usage);

               $debug_output .= ' | Memory Usage: ' . $memory_usage;
            }
         }

         $debug_output .= ' | <a href="' . build_url() . '&amp;explain=1">Explain</a>';
      }
   }

I thought the last part was outside of the DEBUG_EXTRA only block. I'll fix up the article .