Hey all,
I got the "user merge" mod from phpbb modification database.
https://www.phpbb.com/customise/db/mod/user_merge_2/
Reading the comments, I saw someone asking for the ability to choose the earlier join date. I thought, "cool, that makes sense" and I've made an update to the mod and tested it. I thought it's best to discuss my changes to your mod on this board, not the phpbb board directly. Let me know if I'm wrong.
So, what's the proper way to go from here? Make a post with the changes listed in the "mod changes" format of showing code changes with "post after" stuff? Send the updated files?
It's running on PHPbb 3.0.13-PL1
Looking forward to working with you folks.
Nim
Addition I've made to User Merge Mod
Forum rules
The topics in this forum are not for general MOD support, they are for giving the MOD author some feedback, ideas and bug reports.
The topics in this forum are not for general MOD support, they are for giving the MOD author some feedback, ideas and bug reports.
Re: Addition I've made to User Merge Mod
Hi,
If you have a github account then you can make a fork of the mod https://github.com/phpbbmodders-30x-mods/user_merge. Make your changes and submit a pull request.
If you don't have github then stating what changes you made in this topic is fine.
If you have a github account then you can make a fork of the mod https://github.com/phpbbmodders-30x-mods/user_merge. Make your changes and submit a pull request.
If you don't have github then stating what changes you made in this topic is fine.
Re: Addition I've made to User Merge Mod
Well, this is fun! (seriously). I've been using GIT locally, so it seemed like a logical progression to learn how to use GitHub. My account is created (Nimachris again) and I've made my changes and submitted a pull request.RMcGirr83 wrote:Hi,
If you have a github account then you can make a fork of the mod https://github.com/phpbbmodders-30x-mods/user_merge. Make your changes and submit a pull request.
If you don't have github then stating what changes you made in this topic is fine.
Should be cool to see if my changes get to you.
I don't have a test site running. My official site is a private football fan forum and my testbed is on my home PC hidden from the world. If you need me to set something up, let me know.
Hope you like what I've done!
Nim