[MODDB] Ban Hammer

Post your MODs, receive and provide feedback!
Topics in this forum are not for MOD support, they are for giving the author feedback.
Forum rules
The topics in this forum are not for general MOD support, they are for giving the MOD author some feedback, ideas and bug reports.
User avatar
Lord Le Brand
Past Contributor
Past Contributor
Posts: 223
Joined: 08 Sep 2006, 15:44
Real name: Leroy
Location: Parkstad, Limburg, the Netherlands (GMT+1)

Re: [RC4] Ban Hammer

Post by Lord Le Brand »

SamT wrote:
eviL<3 wrote:Nice MOD. It would be nice to have an option of moving all posts to a forum (trash can) for archiving purposes instead of deleting.

I really wanted to do this (and I might be doing this for the version running on my own site) but phpBB does not have a standard trash can yet. It is more then likely I will rewrite this mod when phpBB decides on a soft delete system.

Why don't you add a settable field so the admin can designate a forum ID as being the trash can? plus an option to enable/disable trash canning? :geek:
Image
SamT
Past Contributor
Past Contributor
Posts: 79
Joined: 14 Jun 2009, 16:29
Real name: Sam
Location: Sacramento, CA, USA
Contact:

Re: [RC4] Ban Hammer

Post by SamT »

Lord Le Brand wrote:
SamT wrote:
eviL<3 wrote:Nice MOD. It would be nice to have an option of moving all posts to a forum (trash can) for archiving purposes instead of deleting.

I really wanted to do this (and I might be doing this for the version running on my own site) but phpBB does not have a standard trash can yet. It is more then likely I will rewrite this mod when phpBB decides on a soft delete system.

Why don't you add a settable field so the admin can designate a forum ID as being the trash can? plus an option to enable/disable trash canning? :geek:

I could :o

While I'm at it, I can allow an admin to set the rank they receive as well as a banned member.
igorw
Past Contributor
Past Contributor
Posts: 1967
Joined: 01 Jun 2006, 20:48
Real name: Igor

Re: [RC4] Ban Hammer

Post by igorw »

In fact, acp_users has an option of moving all a users posts. You could copy that code over. You could have a dropdown where you can select the forum to move the posts to. That's easy to implement and doesn't require any new config keys.
SamT
Past Contributor
Past Contributor
Posts: 79
Joined: 14 Jun 2009, 16:29
Real name: Sam
Location: Sacramento, CA, USA
Contact:

Re: [RC4] Ban Hammer

Post by SamT »

eviL<3 wrote:In fact, acp_users has an option of moving all a users posts. You could copy that code over. You could have a dropdown where you can select the forum to move the posts to. That's easy to implement and doesn't require any new config keys.

I was also planning to automate the rank assignment process as well, in an ACP module they will be able to configure the ban hammer, they can choose the forum in which posts are moved to and choose the rank banned users will be assigned.

2 config keys shouldn't be a big deal, I have an automatic module installer anyway (which I need to improve upon).

EDIT: added Planned Features section in first post.
SamT
Past Contributor
Past Contributor
Posts: 79
Joined: 14 Jun 2009, 16:29
Real name: Sam
Location: Sacramento, CA, USA
Contact:

Re: [MODDB] Ban Hammer

Post by SamT »

I have some more info on 1.1, this is the final feature list of features that are being implemented:
  • Ban Hammer accessible via ACP
  • Ban Hammer accessible via MCP
  • ACP Configuration
    • Assign Trash Can Forum, instead of deletion
    • Assign rank to give hammered members
    • Set predefined Ban reasons
  • Three new Permissions
    • a_hammer_ban - If an admin can use the Ban Hammer
    • a_hammer_settings - If an admin can configure the settings
    • m_hammer_ban - if a moderator can use the Ban Hammer
  • Stop Forum Spam integration - A more last minute feature, but it will have the abilty to automatically report Hammered Users.
  • Error Handling - The current version really has nothing aside from "You can't ban the founder" in terms of error handling, but this new version will be more user friendly in that department.
  • Ability to define a usernote - to give to everyone as the Hammering is taking place
  • Archive spammer's PMs - to posts in the "trash forum"

Screen shots will be available in the next few days. :D
User avatar
Obsidian
Supporter
Supporter
Posts: 736
Joined: 13 May 2008, 15:20
Real name: Damian
Contact:

Re: [MODDB] Ban Hammer

Post by Obsidian »

Archive spammer's PMs


You mean spammer's posts?
SamT
Past Contributor
Past Contributor
Posts: 79
Joined: 14 Jun 2009, 16:29
Real name: Sam
Location: Sacramento, CA, USA
Contact:

Re: [MODDB] Ban Hammer

Post by SamT »

Obsidian wrote:
Archive spammer's PMs


You mean spammer's posts?

And PMs.
User avatar
bonelifer
Administrator
Administrator
Posts: 477
Joined: 24 Jun 2006, 17:48
Real name: William
Location: htpc.MythBuntu

Re: [MODDB] Ban Hammer

Post by bonelifer »

You should also add to the FEEDBACK(usernotes) section the same way activating a user does. This would be totally seperate of the definable usernotes.
User avatar
Obsidian
Supporter
Supporter
Posts: 736
Joined: 13 May 2008, 15:20
Real name: Damian
Contact:

Re: [MODDB] Ban Hammer

Post by Obsidian »

bonelifer, do you mean like the "User account activated" log? As in, have a user notes entry automatically added stating "User ban hammered"?
User avatar
bonelifer
Administrator
Administrator
Posts: 477
Joined: 24 Jun 2006, 17:48
Real name: William
Location: htpc.MythBuntu

Re: [MODDB] Ban Hammer

Post by bonelifer »

Yes, that's what shows up in the FEEDBACK section when you activate them.
SamT
Past Contributor
Past Contributor
Posts: 79
Joined: 14 Jun 2009, 16:29
Real name: Sam
Location: Sacramento, CA, USA
Contact:

Re: [MODDB] Ban Hammer

Post by SamT »

Sounds simple enough.
User avatar
onehundredandtwo
Past Contributor
Past Contributor
Posts: 48
Joined: 23 Jul 2009, 19:47

Re: [MODDB] Ban Hammer

Post by onehundredandtwo »

I've noticed Ban Hammer will sometimes give a MySQL Error when the user hasn't been activated.

Code: Select all

UPDATE phpbb_users SET user_birthday = ' 0- 0- 0', user_rank = '52', user_avatar = '', user_avatar_type = 0, user_avatar_width = 0, user_avatar_height = 0, user_sig = '', user_from = '', user_icq = '', user_aim = '', user_yim = '', user_msnm = '', user_jabber = '', user_website = '', user_occ = '', user_interests = '', user_gender = 0 WHERE user_id = 
User avatar
bonelifer
Administrator
Administrator
Posts: 477
Joined: 24 Jun 2006, 17:48
Real name: William
Location: htpc.MythBuntu

Re: [MODDB] Ban Hammer

Post by bonelifer »

It's a known bug. I believe Sam-T has it fixed in the next version. And it's not just sometimes. If they aren't activated and you ban hammer them, you'll always get that error.
User avatar
Obsidian
Supporter
Supporter
Posts: 736
Joined: 13 May 2008, 15:20
Real name: Damian
Contact:

Re: [MODDB] Ban Hammer

Post by Obsidian »

We've never figured out why, either.
User avatar
RMcGirr83
Supporter
Supporter
Posts: 6243
Joined: 30 Nov 2006, 14:23
Real name: Rich McGirr

Re: [MODDB] Ban Hammer

Post by RMcGirr83 »

I think it may be due to this within includes/mcp/mcp_ban_hammer, using quote for colorizingness

// Grab the user id
$sql = 'SELECT *
FROM ' . USERS_TABLE . '
WHERE user_type = ' . USER_NORMAL . ' AND username_clean = "' . $username . '"';


inactive users are not USER_NORMAL, they are USER_INACTIVE :?:

Haven't tested it though.
Post Reply