ok... i hope i haven't messed too much with the code and everything is still working.
Changes:
- Ascraeus now uses constants for the phpbb root path and the php extension. This ensures more security for external applications and modifications (no more overwriting of root path and extension possible through insecure mods and register globals enabled) as well as no more globalizing needed.
- A second change implemented here is an additional short-hand-notation for append_sid(). It is allowed to omit the root path and extension now (for example calling append_sid('memberlist')) - in this case the root path and extension get added automatically. The hook is called after these are added.
This is probably the largest commit i have ever seen . I think even larger than the one where they moved to PHP 5.1. Our so beloved $phpEx is leaving us, and so is $phpbb_root_path. They are both being replaced by PHP_EXT and PHPBB_ROOT_PATH. I like the change, i think it's a good move. No more need to global them in every function. Allthough one good point that was pointed out by drathbun a while ago, is that you cannot use it in double quote strings directly anymore. So it's not possible to do:
Code: Select all
"{$phpbb_root_path}index.$phpEx"
The great thing though is that excactly this problem is addressed and makes it a lot easier, in fact. So instead of doing:
Code: Select all
append_sid("{$phpbb_root_path}index.$phpEx")
You can now simply do:
Code: Select all
append_sid('index')
So instead of making our lives more painful by forcing us to WRITE THE CONSTANT NAMES IN CAPS, it's improved that we actually have to type even less! Now that's what i like!
See the [url=http://code.phpbb.com/repositories/revision/5?rev=8572]revision information[/url] page for all the changes, but believe me, you don't want to read through them. I like phpBB 3.1 more with every change .