[Request] Tabs in profile member

[Dakin Quelia]

Hello,

I have a request. In this [url=http://phpbbmodders.net/articles/3.0/menu_from_tabs/]article[/url], we can add some tabs but I want to do it in profile member. I need this feature to separate main profile informations to custom profile fields.

I tried this code but it doesn't work:

Code: Select all

 <li<!-- IF SCRIPT_NAME == 'memberlist.php?mode=character' --> class="activetab"<!-- ENDIF -->><a href="{U_MEMBERLIST}" title="{L_MEMBERLIST_EXPLAIN}"><span>{L_MEMBERLIST}</span></a></li>

See you soon,

[Elglobo]

Hi Dakin,

You can't do that in a template file since phpBB 3.0.4. You have to write the condition in the PHP file, and assign the template var after. Here is an example. in your PHP file:

Code: Select all

$active_tab_member = ($_SERVER['SCRIPT_NAME'] == '/memberlist.php?mode=character') ? ' class="activetab"' : '';     

Code: Select all

$template->assign_vars(array(
        'ACTIVE_TAB_SEARCH'                => $active_tab_member,     

Finally, in your template file you use {ACTIVE_TAB_SEARCH}.

Have a good day

[Dakin Quelia]

Hi Elglobo,

Thanks for information but it doesn't work.

Here are my template file with tabs:

Code: Select all

<div id="tabs">
   <ul>
       <li {PROFIL_INFOS}><a href="{U_MEMBERLIST_PROFILE}" title="{L_MEMBERLIST_EXPLAIN}"><span>{L_INFO_PROFILE}</span></a></li>
       <li {CHARACTER}><a href="{U_MEMBERLIST_CHARACTER}"><span>{L_INFO_PROFILE_RP}</span></a></li>
   </ul>
</div>

-Edit by Dakin Quelia-
Reason:

I tested this code and it does work. Strange, no?

Code: Select all

$profile_infos = ($_SERVER['SCRIPT_NAME'] ==  '/memberlist.php?mode=viewprofile') ? '' : 'class="activetab"';   Â

See you soon,

[Obsidian]

Be very, very careful there. Messing with $_SERVER variables unescaped is very dangerous.

[Dakin Quelia]

It used in phpBB.

How secure it?

[Obsidian]

It is used in phpBB, however it is used after it is cleaned of possible injects. It's usually a good idea to clean any external data, just to be on the safe side.

[Dakin Quelia]

My request is solved. But I don't know protect $_SERVER.

[Obsidian]

If you're using it in a straight comparison, you should be good. However, if you have to manipulate data using it, you should probably check to see if the data matches what it should carry (this you can do with preg_match() usually). For example, the IP address -- it should be checked and filtered to verify that it /is/ an IP address.