Odd assign_block_vars problem

[comkid]

This is my memberlist_logins.html:

Code: Select all

<!-- INCLUDE overall_header.html -->

<h2 class="solo">{PAGE_TITLE}</h2>

<div class="forumbg">
   <div class="inner"><span class="corners-top"><span></span></span>

   <table class="table1" cellspacing="1">
   <thead>
   <tr>
      <th>Username</th>
      <th>IP</th>
      <th>Time</th>
      <th>Browser Agent</th>
      <th>Successful Login</th>
   </tr>
   </thead>
   <tbody>
   <tr class="bg1">
      <!-- PHP -->
            echo "<td>{$template->_rootref['loginrow']['USERNAME_FULL']}</td>";
      <!-- ENDPHP -->
      <td>{loginrow.IP}</td>
      <td>{loginrow.TIME}</td>
      <td>{loginrow.BROWSER}</td>
      <td>{loginrow.SUCCESSFUL}</td>
   </tr>
   </tbody>
   </table>

   <span class="corners-bottom"><span></span></span></div>
</div>



<hr />

<!-- INCLUDE overall_footer.html -->

This is memberlist.php:

Code: Select all

case 'logins':
        
        $page_title = 'Logins';
        $template_html = 'memberlist_logins.html';
        
        if ($user_id == 0)
        {
            $sql = 'SELECT user_id
                FROM ' . USERS_TABLE . '
                WHERE username = ' . $username;
            $result = $db->sql_query($sql);
            $row = $db->sql_fetchrow($result);
            $db->sql_freeresult($result);
            $user_id = $row['user_id'];
        }
        
        $sql_array = array(
            'SELECT'    => 'u.*, l.*',
            'FROM'      => array(
                USERS_TABLE            => 'u',
            ),
            'LEFT_JOIN' => array(
                array(
                    'FROM'  => array(LOG_TABLE => 'l'),
                    'ON'    => 'l.user_id = ' . $user_id,
                )
            ),
            'WHERE'     => 'u.user_id = ' . $user_id . ' 
                AND log_type = 4',
            'ORDER_BY'  => 'l.log_time'
        );
        
        $sql = $db->sql_build_query('SELECT', $sql_array);
        $result = $db->sql_query($sql);
        
        while ($row = $db->sql_fetchrow($result))
        {
            $template->assign_block_vars('loginrow', array(
                'USERNAME_FULL'    => get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']),
                'IP'            => $row['log_ip'],
                'TIME'            => $user->format_date($row['log_time']),
                'BROWSER'          => $row['log_browser'],
                'SUCCESSFUL'    => ($row['log_successful'] == 1) ? 'Yes' : 'No',
            ));
        }
        
        $db->sql_freeresult($result);
    break; Â

[igorw]

And why exactly are you using <!-- PHP --> tags? Use normal template variables.

[imkingdavid]

Why not just do this:

<!-- INCLUDE overall_header.html -->

<h2 class="solo">{PAGE_TITLE}</h2>

<div class="forumbg">
<div class="inner"><span class="corners-top"><span></span></span>

<table class="table1" cellspacing="1">
<thead>
<tr>
<th>Username</th>
<th>IP</th>
<th>Time</th>
<th>Browser Agent</th>
<th>Successful Login</th>
</tr>
</thead>
<tbody>
<!-- IF .loginrow -->
<!-- BEGIN loginrow -->
<tr class="bg1">
<td>{loginrow.USERNAME_FULL}</td>
<td>{loginrow.IP}</td>
<td>{loginrow.TIME}</td>
<td>{loginrow.BROWSER}</td>
<td>{loginrow.SUCCESSFUL}</td>
</tr>
<!-- END loginrow -->
<!-- ELSE -->
<tr class="bg1">
<td colspan="5">{L_NO_ROWS}</td>
</tr>
<!-- ENDIF -->
</tbody>
</table>

<span class="corners-bottom"><span></span></span></div>
</div>



<hr />

<!-- INCLUDE overall_footer.html -->

[Thoul]

I agree you should just do it the usual way, but here's the reason your approach didn't work. Template files are parsed inside a function of the template class. Inside the scope of that function, $template isn't set. To do it the way you were trying, instead of $template->_rootref, you'd have to use $this->_rootref.