Goodbye $phpEx

[igorw]

Meik (acyd burn) has made a monster commit today that filled up my inbox with 10 emails (they were split up). Here is the commit log:

ok... i hope i haven't messed too much with the code and everything is still working.
Changes:
- Ascraeus now uses constants for the phpbb root path and the php extension. This ensures more security for external applications and modifications (no more overwriting of root path and extension possible through insecure mods and register globals enabled) as well as no more globalizing needed.
- A second change implemented here is an additional short-hand-notation for append_sid(). It is allowed to omit the root path and extension now (for example calling append_sid('memberlist')) - in this case the root path and extension get added automatically. The hook is called after these are added.

This is probably the largest commit i have ever seen . I think even larger than the one where they moved to PHP 5.1. Our so beloved $phpEx is leaving us, and so is $phpbb_root_path. They are both being replaced by PHP_EXT and PHPBB_ROOT_PATH. I like the change, i think it's a good move. No more need to global them in every function. Allthough one good point that was pointed out by drathbun a while ago, is that you cannot use it in double quote strings directly anymore. So it's not possible to do:

Code: Select all

"{$phpbb_root_path}index.$phpEx"

The great thing though is that excactly this problem is addressed and makes it a lot easier, in fact. So instead of doing:

Code: Select all

append_sid("{$phpbb_root_path}index.$phpEx")

You can now simply do:

Code: Select all

append_sid('index')

So instead of making our lives more painful by forcing us to WRITE THE CONSTANT NAMES IN CAPS, it's improved that we actually have to type even less! Now that's what i like!

See the revision information page for all the changes, but believe me, you don't want to read through them. I like phpBB 3.1 more with every change .

[Semi_Deus]

Woa, that IS a big commit

Meik:

[Ganon_Master]

That's great. And the URL parameters are still taken care off the same way?

[igorw]

Yes, the rest is the same .

[harmlessgoat22]

Great idea on their part. I'm happy with the change.

[Prince of phpBB]

Like the changes .. Love Ascraeus

[mtotheikle]

I love this move as well, even though all MOD's will have to be updated now, it makes everything more secure than ever before by even though phpBB has ways to block register globals, some site still have the setting on and bridges or MOD's may get passed the phpBB way of disabling them making the site vulnerably in ways again. Again it is a great update and will make sites a little more secure in my views.

[Obsidian]

Ow ow ow ow, jaw hurts, it hit the floor at supersonic speed.

[Brandon]

Wow that is a big change. Must be a pain trying to remember all these coding tags I mean I would forget in an instant!

[harmlessgoat22]

I hope Miek used Dreamweaver or some other program that can search through whole folders at a time for stuff...that would have helped a ton in looking for everywhere $phpEx and $phpbb_root_path are used.

[Brandon]

Oh yes Dreamweaver would be excellent for that certain occasion.

[momentum]

grep

Craig.

[Obsidian]

Waiiit a minute...

Then how are MOD authors supposed to write scripts for use in subdirectories?

[Ganon_Master]

Waiiit a minute...

Then how are MOD authors supposed to write scripts for use in subdirectories?

The append_sid function allows for short notation, but includes still have to be done the (sort of) old fashion way.

Code: Select all

include(PHPBB_ROOT_PATH . 'includes/functions.' . PHP_EXT);  

[harmlessgoat22]

You could also still use the shorthand:

Code: Select all

append_sid('includes/functions.'); 

Just like including a language file, you can put folders in there.