Addition I've made to User Merge Mod

Post your MODs, receive and provide feedback!
Topics in this forum are not for MOD support, they are for giving the author feedback.
Forum rules
The topics in this forum are not for general MOD support, they are for giving the MOD author some feedback, ideas and bug reports.
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable
Nimachris
New member
New member
Posts: 3
Joined: 09 Mar 2015, 00:03
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Addition I've made to User Merge Mod

Postby Nimachris » 09 Mar 2015, 00:13

Hey all,

I got the "user merge" mod from phpbb modification database.

https://www.phpbb.com/customise/db/mod/user_merge_2/

Reading the comments, I saw someone asking for the ability to choose the earlier join date. I thought, "cool, that makes sense" and I've made an update to the mod and tested it. I thought it's best to discuss my changes to your mod on this board, not the phpbb board directly. Let me know if I'm wrong.

So, what's the proper way to go from here? Make a post with the changes listed in the "mod changes" format of showing code changes with "post after" stuff? Send the updated files?

It's running on PHPbb 3.0.13-PL1

Looking forward to working with you folks.

Nim

User avatar
RMcGirr83
Past Contributor
Past Contributor
Posts: 6243
Joined: 30 Nov 2006, 14:23
Real name: Rich McGirr
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Re: Addition I've made to User Merge Mod

Postby RMcGirr83 » 09 Mar 2015, 10:17

Hi,

If you have a github account then you can make a fork of the mod https://github.com/phpbbmodders-30x-mods/user_merge. Make your changes and submit a pull request.

If you don't have github then stating what changes you made in this topic is fine.

Nimachris
New member
New member
Posts: 3
Joined: 09 Mar 2015, 00:03
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Re: Addition I've made to User Merge Mod

Postby Nimachris » 09 Mar 2015, 17:48



[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Return to “MOD Feedback”

Who is online

Users browsing this forum: No registered users and 6 guests