Need help updating sql via template form

[guyb]

[Obsidian]

Hi there. From what it seems to me, upon firing the SQL query you are using variables that are not set.

Additionally, you are pulling data right from $HTTP_POST_VARS, which is highly insecure and not recommended if you are using phpBB3. You'll want to read this if that is the case: http://wiki.phpbb.com/Request_var

[guyb]

[guyb]

[Obsidian]

[guyb]

[Obsidian]

[guyb]

[Obsidian]

Uhh, not sure what you are trying to do there with the value of the submit button, because submit only returns 1 or 0 for post submission -- value is only the text displayed for the button's visible label.
You may need another hidden input there for the mode.

[guyb]

If you were referring to this: "value="{L_ADMIN_AUCTION_OFFER_FIELD_EDIT}"" that's just a preset text variable for the button. This mod uses that approach a lot instead of hardcoding a text phrase in the site pages.

[guyb]

[Obsidian]

Hmmm...I really don't have enough experience with phpBB2 coding methods, so I would suggest you try going to this site, http://www.phpbb2refugees.com/

[guyb]

[Obsidian]

It looks like the second example initializes $mode if the appropriate GET or POST var isn't set anyways, which is actually a smart thing to do (as it is error-proofing that way), however the code itself isn't quite so clean and (if this were in phpBB3) could be a lot easier to read.