Zephyr

[Obsidian]

Okay, I'm looking for some opinions on a posting handler I've made, which I'm calling Zephyr.

http://code.assembla.com/phpbb_crs_xerx ... zephyr.php

What do you all think of it?

Are there things I need to change?

Also, regarding zephyr::load_default_data(), what data /do/ I need by default? Do I not need any?
Have I coded it correctly to reply to topics, too?

[igorw]

I like the name.

I would find it cool if you put stuff like backup_user() in a separate class (did you base it off my phpbbmodders_lib one?). But I like the way you use clone there.

All in all, it looks pretty usable. I didn't try it out though.

[Obsidian]

[Obsidian]

Okay, I ran it, hit a few bugs, and ironed them all out.

It works like a charm!

Revisions 63 & 64 fixes a lot of globaling issues, and stuff that caused it to break.
http://code.assembla.com/phpbb_crs_xerx ... zephyr.php

[igorw]

[Obsidian]

Well, no, I don't need to reuse it, really.

Besides, I don't like playing with an external class for it. More simple to just keep it a set of private functions, I don't want a mess of classes like vBulletin has.

[igorw]

You need to be less practical and think outside the box.

[Ganon_Master]

[Obsidian]

Well, I don't need to use it outside of Zephyr, so why should I separate them, then?

[igorw]

Simple: maybe somebody else wants to create a new box that uses parts of yours.

[Obsidian]

Ah, but then there's your phpbb_auth_handler that they can use.

[igorw]

That's my point. Why duplicate behaviour if you can use existing?

[Obsidian]