Addition I've made to User Merge Mod

Post your MODs, receive and provide feedback!
Topics in this forum are not for MOD support, they are for giving the author feedback.
Forum rules
The topics in this forum are not for general MOD support, they are for giving the MOD author some feedback, ideas and bug reports.
Nimachris
New member
New member
Posts: 3
Joined: 09 Mar 2015, 00:03

Addition I've made to User Merge Mod

Postby Nimachris » 09 Mar 2015, 00:13

Hey all,

I got the "user merge" mod from phpbb modification database.

https://www.phpbb.com/customise/db/mod/user_merge_2/

Reading the comments, I saw someone asking for the ability to choose the earlier join date. I thought, "cool, that makes sense" and I've made an update to the mod and tested it. I thought it's best to discuss my changes to your mod on this board, not the phpbb board directly. Let me know if I'm wrong.

So, what's the proper way to go from here? Make a post with the changes listed in the "mod changes" format of showing code changes with "post after" stuff? Send the updated files?

It's running on PHPbb 3.0.13-PL1

Looking forward to working with you folks.

Nim

User avatar
RMcGirr83
Past Contributor
Past Contributor
Posts: 6243
Joined: 30 Nov 2006, 14:23
Real name: Rich McGirr

Re: Addition I've made to User Merge Mod

Postby RMcGirr83 » 09 Mar 2015, 10:17

Hi,

If you have a github account then you can make a fork of the mod https://github.com/phpbbmodders-30x-mods/user_merge. Make your changes and submit a pull request.

If you don't have github then stating what changes you made in this topic is fine.

Nimachris
New member
New member
Posts: 3
Joined: 09 Mar 2015, 00:03

Re: Addition I've made to User Merge Mod

Postby Nimachris » 09 Mar 2015, 17:48

RMcGirr83 wrote:Hi,

If you have a github account then you can make a fork of the mod https://github.com/phpbbmodders-30x-mods/user_merge. Make your changes and submit a pull request.

If you don't have github then stating what changes you made in this topic is fine.

Well, this is fun! (seriously). I've been using GIT locally, so it seemed like a logical progression to learn how to use GitHub. My account is created (Nimachris again) and I've made my changes and submitted a pull request.

Should be cool to see if my changes get to you. :popcorn:

I don't have a test site running. My official site is a private football fan forum and my testbed is on my home PC hidden from the world. If you need me to set something up, let me know.

Hope you like what I've done! :rock:

Nim


Return to “MOD Feedback”

Who is online

Users browsing this forum: No registered users and 1 guest